Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser monitoring injection logic hardening #2465

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Commits on Feb 27, 2024

  1. browser monitoring injection logic hardening

    These changes introduce hardening to the logic that determines whether
    or not to inject the browser agent script tag.
    
    In particular, the following 2 issues have been addressed:
    
    1. If either `#traced_call` or `#should_instrument?` encounter any
       exceptions, these exceptions should be handled and logged without
       impacting the observed web application.
    2. Allow a response headers hash to use symbols for values.
    
    Closes #2462
    fallwith committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    799d12b View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. browser monitoring 2465 updates

    - we want to rescue all exceptions spawning from checks to determine
      whether the browser agent should be inserted, but we can't rescue
      `#traced_call` without breaking expected workflows
    - add a unit test for a hash with a symbol as the content type value
    - added a README.md entry
    fallwith committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5ef2fbd View commit details
    Browse the repository at this point in the history
  2. browser monitoring: #html? is private

    use `#send` in the test
    fallwith committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    81970d5 View commit details
    Browse the repository at this point in the history