Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thor scaffold command #2412

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Update thor scaffold command #2412

merged 3 commits into from
Jan 23, 2024

Conversation

tannalynn
Copy link
Contributor

@tannalynn tannalynn commented Jan 23, 2024

Fixes the insert point for the default_source.rb, since it was no longer working after updates we made to default_source.rm
Also, I fixed the extra line that we've had in the chain instrumentation. I always remove it, and I know we've discussed how that line is redundant in other PRs that used the scaffold, so I updated it. (The method gets redefined immediately after that line.)

@tannalynn tannalynn marked this pull request as ready for review January 23, 2024 22:30
Copy link

SimpleCov Report

Coverage Threshold
Line 93.69% 93%
Branch 71.84% 71%

Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannalynn tannalynn merged commit 11d212e into dev Jan 23, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants