Add ViewComponent regression test #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
requested review from
fallwith,
kaylareopelle and
tannalynn
as code owners
fallwith
previously approved these changes
Jan 24, 2024
kaylareopelle
previously approved these changes
Jan 24, 2024
tannalynn
reviewed
Jan 24, 2024
| @@ -1,23 +1,25 @@ | |||
| # New Relic Ruby Agent Release Notes | |||
|
|
|||
|
|
|||
| ## dev | |||
| ## v9.7.1 | |||
There was a problem hiding this comment.
jsyk, you don't actually need to update the version number, the prerelease automation will do it automatically. No need to change it back though! the automation won't break if its already changed.
There was a problem hiding this comment.
I didn't know this! Very good to know ◡̈
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
hannahramadan
dismissed stale reviews from kaylareopelle and fallwith
via
d44da83
SimpleCov Report
|
kaylareopelle
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewComponent errors are being suppressed, as #2410 reported. Once the fix from that PR is merged, our new test should pass.
Update: fix merged and new test passing!