Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't suppress view component rendering errors #2410

Merged

Commits on Jan 24, 2024

  1. Remove error suppression in render_in

    We should be able to se error pages, specially in when Rails.env is
    development. The piece of code that was removed here
    prevented from happening. Instead, it would have the `render_in` method
    return `nil` when an error happened, resulting in either a blank page,
    or an incomplete page.
    
    I believe we also want to raise errors in production. We should not make
    a decision here, whether the error should be suppressed. Otherwise we
    are making the assumption "incomplete pages are better than error
    pages", which may be the correct assumption under some circumstances,
    but not under other circumstances.
    
    Fixes ViewComponent/view_component#1981
    mjacobus committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    becdad9 View commit details
    Browse the repository at this point in the history