Remove Ruby/Thread and Ruby/Fiber spans #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannalynn
requested review from
fallwith,
hannahramadan and
kaylareopelle
as code owners
fallwith
reviewed
Jan 5, 2024
Co-authored-by: James Bunch <fallwith@gmail.com>
SimpleCov Report
|
fallwith
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce confusing information being reported, the agent no longer creates the new spans for
Ruby/ThreadandRuby/Fiber. The agent will still record anything happening inside of these threads/fibers correctly. The parents will still also be created correctly. We did have to make some adjustment to segment parent logic to accommodate the removal of these spans while maintaining consistently correct parent nesting.I decided to leave the concurrent ruby spans as is, since those are more likely to be useful information for customers compared to the ruby/thread spans.
resolves #2371