Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2247, removes unused variable warnings in tests suite #2250

Merged
merged 1 commit into from
Oct 10, 2023
Merged

#2247, removes unused variable warnings in tests suite #2250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/new_relic/agent/configuration/manager_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ def test_apply_transformations_reraises_errors
def test_auto_determined_values_stay_cached
name = :knockbreck_manse

dd = DependencyDetection.defer do
DependencyDetection.defer do
named(name)
executes { use_prepend? }
end
Expand All @@ -512,7 +512,7 @@ def test_auto_determined_values_stay_cached
def test_unsatisfied_values_stay_cached
name = :tears_of_the_kingdom

dd = DependencyDetection.defer do
DependencyDetection.defer do
named(name)

# guarantee the instrumentation's dependencies are unsatisfied
Expand Down
1 change: 0 additions & 1 deletion test/new_relic/agent/monitors/synthetics_monitor_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ def test_records_synthetics_state_from_header
end

def test_records_synthetics_info_header_if_available
key = SyntheticsMonitor::SYNTHETICS_HEADER_KEY
synthetics_payload = [VERSION_ID] + STANDARD_DATA
info_payload = <<~PAYLOAD
{
Expand Down
2 changes: 1 addition & 1 deletion test/new_relic/agent/tracer_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ def test_traced_threads_dont_keep_using_finished_transaction
txn = Tracer.start_transaction(name: 'Controller/blogs/index', category: :controller)
threads = []
threads << Thread.new do
segment = Tracer.start_segment(name: 'Custom/MyClass/myoperation')
Tracer.start_segment(name: 'Custom/MyClass/myoperation')
sleep(0.01) until txn.finished?

threads << Thread.new do
Expand Down
12 changes: 3 additions & 9 deletions test/new_relic/dependency_detection_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,11 +211,9 @@ def test_config_enabling_with_enabled
end

def test_config_enabling_with_auto
executed = false

dd = DependencyDetection.defer do
named(:testing)
executes { executed = true }
executes { true }
end

with_config(:'instrumentation.testing' => 'auto') do
Expand All @@ -228,11 +226,9 @@ def test_config_enabling_with_auto
end

def test_config_enabling_with_prepend
executed = false

dd = DependencyDetection.defer do
named(:testing)
executes { executed = true }
executes { true }
end

with_config(:'instrumentation.testing' => 'prepend') do
Expand All @@ -245,11 +241,9 @@ def test_config_enabling_with_prepend
end

def test_config_enabling_with_chain
executed = false

dd = DependencyDetection.defer do
named(:testing)
executes { executed = true }
executes { true }
end

with_config(:'instrumentation.testing' => 'chain') do
Expand Down
Loading