Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2154, replace "start up" to "start-up" #2249

Merged
merged 1 commit into from
Oct 10, 2023
Merged

#2154, replace "start up" to "start-up" #2249

merged 1 commit into from
Oct 10, 2023

Conversation

chahmedejaz
Copy link
Contributor

@chahmedejaz chahmedejaz commented Oct 10, 2023 •
edited
Loading

Overview

This PR replaces the "start up" with "start-up" and resolves #2154.

Submitter Checklist:

  • Include a link to the related GitHub issue, if applicable
  • Include a security review link, if applicable

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Oct 10, 2023
kaylareopelle
kaylareopelle approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @chahmedejaz! The failures in the CI are unrelated to your PR. This looks good to me!

@kaylareopelle kaylareopelle merged commit d5359d1 into newrelic:dev Oct 10, 2023
24 of 26 checks passed
@chahmedejaz
Copy link
Contributor Author

Thank you, @chahmedejaz! The failures in the CI are unrelated to your PR. This looks good to me!

Thank you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@fallwith fallwith Awaiting requested review from fallwith fallwith is a code owner

@hannahramadan hannahramadan Awaiting requested review from hannahramadan hannahramadan is a code owner

@tannalynn tannalynn Awaiting requested review from tannalynn tannalynn is a code owner

Assignees
No one assigned
Labels
community To tag external issues and PRs submitted by the community hacktoberfest-accepted
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace start up with start-up
3 participants
@chahmedejaz @CLAassistant @kaylareopelle