Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe Rails subscriber implementation #2179

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Describe Rails subscriber implementation #2179

merged 3 commits into from
Sep 5, 2023

Commits on Aug 29, 2023

  1. Describe Rails subscriber implementation 

    The agent uses a non-traditional way to subscribe to Rails events.
Instead of passing a block to ActiveSupport::Notifications.subscribe, the
agent defines a #start and #finish method, which Rails responds to.
This is due to a threading issue discovered on initial instrumentation.
Issue: rails/rails#12069
Rails code: https://github.com/rails/rails/blob/ed5af004598fa7645fec2210453cca00f4b59168/activesupport/lib/active_support/notifications/fanout.rb#L320
    @hannahramadan
    hannahramadan committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    1df9227 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Reference issue in comment

    @hannahramadan
    hannahramadan authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    6c8a535 View commit details
    Browse the repository at this point in the history

  2. Full link

    @hannahramadan
    hannahramadan authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    621c725 View commit details
    Browse the repository at this point in the history