Sidekiq args filtration #2177
Merged
Sidekiq args filtration #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added pre-filtering logic to the `Attribute::Processing` class, currently used only by Sidekiq - Added new `sidekiq.args.include` and `sidekiq.args.exclude` configuration options to permit the capturing of a subset of Sidekiq job arguments - Rewrote all existing Sidekiq multiverse tests. The suite should now complete in ~4 seconds instead of 32 and doesn't require Mocha.
explain `sidekiq.args.include` and `sidekiq.args.exclude` in `CHANGELOG.md`
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
We don't typically break up the description lines, but our RuboCop todo file has a threshold of the longest known line so let's not break that threshold.
|
resolves #2150 |
fallwith
commented
Aug 28, 2023
Sidekiq args CHANGELOG entry grammar and typo fixes Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
Sidekiq args CHANGELOG entry improvements Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
We already use "capture" so stick with that instead of saying something along the lines of "sent to New Relic".
Sidekiq arg capturing entry wording fix Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
Sidekiq arg capturing entry: specify YAML as the syntax to use for the newrelic.yml code block Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
Update the CHANGELOG entry for Sidekiq args filtration to more clearly explain regexp, link to RubyDocs for regexp, and explain inexact matches.
tannalynn
reviewed
Aug 29, 2023
Sidekiq args filtering - in `default_source.rb`, use `dynamic_name: true`, and use heredocs for the descriptions. By using `dynamic_name: true`, we don't have to have an ignore list for config scanning.
remove junk that was accidentally added
Given that the existing attributing processing methods and the new attribute pre-filtering methods don't share any content or logic, have the pre-filtering methods live in a separate dedicated `AttributePreFiltering` class.
SIdekiq args filtering entry: "has" -> "hash" typo fix Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
sidekiq.args.include description text updates Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
sidekiq.args.exclude description text updates Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
the "without exclude" test should actually operate without an exclude list. thanks, @kaylareopelle
SimpleCov Report
|
kaylareopelle
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute pre-filtering, Sidekiq args filtering
Attribute::Processingclass,currently used only by Sidekiq
sidekiq.args.includeandsidekiq.args.excludeconfiguration options to permit the capturing of a subset of Sidekiq
job arguments
complete in ~4 seconds instead of 32 and doesn't require Mocha.