Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Roda instrumentation #2144

Merged
merged 32 commits into from
Aug 10, 2023
Merged

Add Roda instrumentation #2144

merged 32 commits into from
Aug 10, 2023

Commits on Jul 25, 2023

  1. Initial commit Roda instrumentation 

    Adds prepend and chaining options for Roda v3.19.0+
    @hannahramadan
    hannahramadan committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    283279b View commit details
    Browse the repository at this point in the history

  2. disable Lint/DuplicateMethods

    @hannahramadan
    hannahramadan committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    64b6ac9 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Address feedback

    @hannahramadan
    hannahramadan committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    31a1ee2 View commit details
    Browse the repository at this point in the history

  2. Remove uncessary alias

    @hannahramadan
    hannahramadan committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4612fe8 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Refactor naming method

    @hannahramadan
    hannahramadan committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    6ee5ef9 View commit details
    Browse the repository at this point in the history

  2. Roda test files

    @hannahramadan
    hannahramadan committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    05cc30f View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Add some tests

    @hannahramadan
    hannahramadan committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    67cacf6 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Add test

    @hannahramadan
    hannahramadan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    1852fb9 View commit details
    Browse the repository at this point in the history

  2. test: remove minitest from env

    @hannahramadan
    hannahramadan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    0926775 View commit details
    Browse the repository at this point in the history

  3. debug txn

    @hannahramadan
    hannahramadan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    db7734d View commit details
    Browse the repository at this point in the history

  4. Ruby 2.4 fix

    @hannahramadan
    hannahramadan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8fbbe4e View commit details
    Browse the repository at this point in the history

  5. test: and another one

    @hannahramadan
    hannahramadan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    ca48d74 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. test: middleware disabling

    @hannahramadan
    hannahramadan committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    cc43194 View commit details
    Browse the repository at this point in the history

  2. test: middleware fix

    @hannahramadan
    hannahramadan committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    13ca306 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into roda_instrumentation

    @hannahramadan
    hannahramadan committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    b91579d View commit details
    Browse the repository at this point in the history

  4. Add CHANGELOG

    @hannahramadan
    hannahramadan committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    10d8b0e View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Add tests

    @hannahramadan
    hannahramadan committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    6ec648c View commit details
    Browse the repository at this point in the history

  2. Refactor

    @hannahramadan
    hannahramadan committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    160a64b View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG.md 

    Co-authored-by: James Bunch <fallwith@gmail.com>
    @hannahramadan @fallwith
    hannahramadan and fallwith authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    72010af View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: James Bunch <fallwith@gmail.com>
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
    @hannahramadan @fallwith @kaylareopelle
    3 people authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    8a57394 View commit details
    Browse the repository at this point in the history

  5. Update test/multiverse/suites/roda/roda_instrumentation_test.rb 

    Co-authored-by: James Bunch <fallwith@gmail.com>
    @hannahramadan @fallwith
    hannahramadan and fallwith authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    2834638 View commit details
    Browse the repository at this point in the history

  6. Updates

    @hannahramadan
    hannahramadan committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    545c126 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: James Bunch <fallwith@gmail.com>
    @hannahramadan @fallwith
    hannahramadan and fallwith authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    57ca227 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Code feedback

    @hannahramadan
    hannahramadan committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    c79d978 View commit details
    Browse the repository at this point in the history

  2. Update lib/new_relic/agent/instrumentation/roda/instrumentation.rb 

    Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
    @hannahramadan @kaylareopelle
    hannahramadan and kaylareopelle authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    e4ca1e0 View commit details
    Browse the repository at this point in the history

  3. Don't stub any_instance

    @hannahramadan
    hannahramadan committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    8123d11 View commit details
    Browse the repository at this point in the history

  4. Move require to top of file

    @hannahramadan
    hannahramadan committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    c08cf6b View commit details
    Browse the repository at this point in the history

  5. Relocate rack/browser requires

    @hannahramadan
    hannahramadan committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    9b89d72 View commit details
    Browse the repository at this point in the history

  6. Refactor

    @hannahramadan
    hannahramadan committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    ed60437 View commit details
    Browse the repository at this point in the history

  7. put requires back

    @hannahramadan
    hannahramadan committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    8e90f4f View commit details
    Browse the repository at this point in the history

  8. remove from instrum class

    @hannahramadan
    hannahramadan committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    6b1fcc1 View commit details
    Browse the repository at this point in the history

  9. Update lib/new_relic/agent/instrumentation/roda/roda_transaction_name… 

    …r.rb

Co-authored-by: James Bunch <fallwith@gmail.com>
    @hannahramadan @fallwith
    hannahramadan and fallwith authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    138176b View commit details
    Browse the repository at this point in the history