CI: multiverse - unpin webrick #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
permit v1.8.1+
* update FakeServer to respect `ENV['DEBUG']` and use $stdout instead of /dev/null for all output when set * update FakeCollector to not attempt `#rewind` on objects that don't support it
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
|
manual nightly run: https://github.com/newrelic/newrelic-ruby-agent/actions/runs/5663343396 |
|
resolves #1774 |
kaylareopelle
approved these changes
Jul 26, 2023
hannahramadan
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENV['DEBUG']. Going forward if there are any errors happening that are fake server related, we need only to set theDEBUGenvironment variable to see what is going on.#rewindon objects that don't support it (for improved WEBrick compatibility)