Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old method #2139

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Remove old method #2139

merged 1 commit into from
Jul 19, 2023

Conversation

hannahramadan
Copy link
Contributor

new_relic_trace_controller_action is defined and added to customer Sinatra applications, but is never called.

@hannahramadan
Remove old method
ef63c8c 
new_relic_trace_controller_action is defined but never used
@hannahramadan hannahramadan marked this pull request as ready for review July 19, 2023 21:03
@github-actions
Copy link

SimpleCov Report

Coverage Threshold
Line 94.26% 94%
Branch 85.75% 85%

@hannahramadan hannahramadan marked this pull request as draft July 19, 2023 21:26
tannalynn
tannalynn approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@tannalynn tannalynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We literally can't find where this method has ever been used. Even when it was first introduced, it didn't do anything and wasn't used. ¯\(ツ)/¯

@hannahramadan hannahramadan marked this pull request as ready for review July 19, 2023 22:17
@hannahramadan hannahramadan merged commit 7834390 into dev Jul 19, 2023
26 checks passed
@hannahramadan hannahramadan deleted the bury_dead_code branch July 19, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannalynn tannalynn tannalynn approved these changes

@fallwith fallwith Awaiting requested review from fallwith fallwith is a code owner

@kaylareopelle kaylareopelle Awaiting requested review from kaylareopelle kaylareopelle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahramadan @tannalynn