Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Test for the health of all code base URLs #2127

Merged
merged 4 commits into from
Jul 11, 2023
Merged

CI: Test for the health of all code base URLs #2127

merged 4 commits into from
Jul 11, 2023

Commits on Jul 11, 2023

  1. CI: Test for the health of all code base URLs 

    - Add a new unit test class for testing the health of all URLs defined in the code base. See the comments in `test/new_relic/healthy_urls_test.rb` for more details
- Update `ci_cron.yml` to set a `CI_CRON` env var to true
- Update `.ruboycop.yml` to permit `throw` and `catch` calls without parens
- Add new `skip_unless_ci_cron` helper to permit tests to only run via `ci_cron.yml`
- Add new `skip_unless_newest_ruby` helper to permit tests to only run on the newest Ruby
- Add new `agent_root` helper to permit tests to quickly get to the agent root
- Fix 5 URLs that the new test caught

resolves #2126
    @fallwith
    fallwith committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    a14eb38 View commit details
    Browse the repository at this point in the history

  2. CI: don't run URL health checks via env tests 

    Prevent the `env` tests from running the URL health check tests
    @fallwith
    fallwith committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    d101509 View commit details
    Browse the repository at this point in the history

  3. CI: fix newest_ruby helper 

    always compare gem version objects
    @fallwith
    fallwith committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    0be5af5 View commit details
    Browse the repository at this point in the history

  4. CI: url checker - use 'break' 

    we only need to break out of the current loop, so throw/catch is
overkill
    @fallwith
    fallwith committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    76c95a8 View commit details
    Browse the repository at this point in the history