Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save navigation to finished? #1983

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

kaylareopelle
Copy link
Contributor

Overview

Resolves #1981

Submitter Checklist:

  • Include a link to the related GitHub issue, if applicable
  • Include a security review link, if applicable

Testing

The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

fallwith
fallwith previously approved these changes May 1, 2023
@github-actions
Copy link

github-actions bot commented May 1, 2023

SimpleCov Report

Coverage Threshold
Line 93.98% 93%
Branch 85.4% 85%

@kaylareopelle kaylareopelle merged commit 4772d55 into dev May 1, 2023
@kaylareopelle
Copy link
Contributor Author

kaylareopelle commented May 1, 2023

👇 Leaving this branch for potential testers.

@kaylareopelle kaylareopelle deleted the bugfix/finished-9-2-1 branch June 5, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newrelic_rpm gem (9.2.1) displaying errors in rails console
2 participants