Log request headers #1839
Merged
Log request headers #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
commented
Feb 24, 2023
Previously, AbstractRequest subclass objects were being printed where a hash of headers was expected. Now, if the headers argument is an instance of the AbstractRequest class its headers method will be called and used in the log message.
kaylareopelle
force-pushed
the
log-request-headers
branch
from
030b30a
to
f587197
Compare
fallwith
previously approved these changes
Feb 24, 2023
kaylareopelle
dismissed stale reviews from fallwith and tannalynn
via
0b28bf7
* Remove define_method arg * Use name instead of __method__
fallwith
previously approved these changes
Feb 25, 2023
fallwith
approved these changes
Feb 25, 2023
SimpleCov Report
|
Merged
|
Released in v9.1.0 of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#headersmethod to allNewRelic::Agent::HTTPClients::AbstractRequestsubclasses that returns a hash of the headers for the requestNewRelic::Agent::Transaction::DistributedTracer#log_request_headersto check theheadersargument's class. If it is an instance ofNewRelic::Agent::HTTPClients::AbstractRequest, the#headersmethod will be called and logged. If not, the argument as-passed will be printedResolves #1657