Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NEW_RELIC_ID_HEADER #1808

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

esquith
Copy link
Contributor

@esquith esquith commented Feb 8, 2023

Before contributing, please read our contributing guidelines and code of conduct.

Overview

Removing an orphaned constant

Submitter Checklist:
/issues/1130

Testing

The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Feb 8, 2023
@esquith esquith marked this pull request as ready for review February 8, 2023 22:46
Copy link
Contributor

@hannahramadan hannahramadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @esquith. Thanks for ensuring that the constant NEWRELIC_ID_HEADER defined and used in cross_app_monitor_test.rb remained 🤠

@hannahramadan hannahramadan merged commit 732acea into newrelic:dev Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs submitted by the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants