Allow set_transaction_name to change name and category of current transaction.
#1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimpleCov Report
|
fallwith
requested changes
Feb 6, 2023
Co-authored-by: James Bunch <fallwith@gmail.com>
fallwith
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates how
set_transaction_nameworks so it functions more as expected and accomplishes what customers have expected it to do. Now, when set_transaction_name is called with a different category that is already assigned, the category and name will be changed to what is passed in. Previously, nothing would happen if the category was different.The
set_transaction_nameapi docs did not need to be updated because the way it is worded already implies that this is how it was supposed to work in the first place.closes #1064