Remove unused error class BackgroundLoadingError
#1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class is introduced by newrelic@f2168ff#diff-61a8aeaee4649719c4136512deca7e826560b227c576e18114154a6082311830R47. But it became unused at newrelic@9e1b428#diff-918c7f140adbe155d6f5234c69b3373615a0e2bb395ee3339182e229c60f0156L52.
github-actions
bot
added
the
community
|
Thank you for finding this, @ohbarye. It is surprising to see that the code remained hidden for almost 13 years! We very much appreciate your contribution. |
fallwith
approved these changes
Oct 16, 2022
fallwith
added a commit
that referenced
this pull request
Oct 16, 2022
update the cleanup entry for the v8.12.0 release to include the work done with #1548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I found
BackgroundLoadingErrorclass is no longer used anywhere.The class is introduced by this commit (Apr 23, 2009), and it became unused by this commit (Feb 10, 2010).
Submitter Checklist:
Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist