Increase custom_insights_events.max_samples_stored #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
force-pushed
the
custom_events_reservoir_limit
branch
from
b2de8bc
to
cb34d08
Compare
fallwith
previously approved these changes
Oct 13, 2022
The previous default value was 1000. The new default is 3000. This new number is based on OATS results from multiple language agents
kaylareopelle
dismissed stale reviews from fallwith and tannalynn
via
cbc5b38
kaylareopelle
force-pushed
the
custom_events_reservoir_limit
branch
from
cb34d08
to
cbc5b38
Compare
tannalynn
approved these changes
Oct 13, 2022
SimpleCov Report
|
| @@ -2004,7 +2004,7 @@ def self.enforce_fallback(allowed_values: nil, fallback: nil) | |||
| :description => 'If `true`, the agent captures [custom events](/docs/insights/new-relic-insights/adding-querying-data/inserting-custom-events-new-relic-apm-agents).' | |||
| }, | |||
| :'custom_insights_events.max_samples_stored' => { | |||
| :default => 1000, | |||
| :default => 3000, | |||
There was a problem hiding this comment.
Is there any impact to increasing this number? I'm wondering how we can up with 1000 in the first place, and why 3000 is the new number.
There was a problem hiding this comment.
Hi Hannah! Please see this slack thread (internal)
1000 is actually lower than what all the other agents have at this time. The spec default is 10K per limit, so we're getting closer to the spec with a smaller performance impact by changing the value to 3K.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The previous default value for
custom_insights_events.max_samples_storedwas 1000. The new default is 3000.This new number is based on OATS results from multiple language agents in an effort to reduce the number of dropped custom insights events.
Closes #1540