Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "invoked" metrics to more libraries #1923

Closed
3 tasks
kaylareopelle opened this issue Apr 4, 2023 · 2 comments · Fixed by #2189
Closed
3 tasks

Add "invoked" metrics to more libraries #1923

kaylareopelle opened this issue Apr 4, 2023 · 2 comments · Fixed by #2189
Assignees
Labels
1 Story Point Estimate technical debt

Comments

@kaylareopelle
Copy link
Contributor

Description

We added a metric that registers whenever the concurrent-ruby instrumentation is invoked to differentiate between times the library is loaded by Rails and times the library is independently used by the customer.

Let's add more "invoked"-type metrics that record the first time some instrumentation is invoked so we can get a better sense of the instrumentation our customers use.

Acceptance Criteria

  • Libraries using prepend/chain_instrument methods reviewed for compatibility with record_metric_once
  • "invoked"-type metrics are added to the libraries that seem like good candidates
  • Angler's metric_names.txt is updated to include the new metrics

Design Consideration/Limitations

We may want to consider dropping the Supportability/Instrumentation/#{LibraryName}/#{Prepend || MethodChaining} metrics in favor of these metrics so that we know when instrumentation is used rather than installed.

Dependencies

Angler updates to allow us to observe the new data

Estimates

S

@workato-integration
Copy link

@workato-integration workato-integration bot changed the title Add "invoked" metrics to more libraries Add "invoked" metrics to more libraries Apr 4, 2023
@fallwith fallwith added this to the Feature smash! milestone Jun 6, 2023
@fallwith fallwith added the estimate Issue needing estimation label Jun 6, 2023
@kaylareopelle
Copy link
Contributor Author

When we discussed this issue during an estimation session, we decided adding "invoked" metrics would be the most appropriate for instrumented gems that are dependencies of other popular gems.

For these gems, the current installation metrics aren't enough to give us a clear picture of how many users leverage these libraries.

@kford-newrelic kford-newrelic added 1 Story Point Estimate and removed estimate Issue needing estimation labels Jun 10, 2023
@fallwith fallwith self-assigned this Sep 1, 2023
fallwith added a commit that referenced this issue Sep 6, 2023
Following a pattern established by the concurrent-ruby instrumentation,
establish a way for all instrumentation to differentiate between the
simple presence of an instrumented gem and its invocation.

resolves #1923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Story Point Estimate technical debt
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants