Skip to content

Commit

Permalink
CI: better test helper name
Browse files Browse the repository at this point in the history
label the tin better
  • Loading branch information
fallwith committed Aug 10, 2023
1 parent 6d10f1e commit aabe6c7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion test/helpers/misc.rb
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def skip_unless_minitest5_or_above
skip 'This test requires MiniTest v5+'
end

def skip_unless_rails_gte(min_version)
def skip_unless_no_rails_or_rails_version_at_or_above(min_version)
return unless defined?(Rails) && Rails.respond_to?(:version)
return if Gem::Version.new(Rails.version) >= Gem::Version.new(min_version)

Expand Down
4 changes: 2 additions & 2 deletions test/new_relic/agent/transaction/request_attributes_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def test_by_default_only_a_base_set_of_request_headers_are_captured
end

def test_if_allow_all_headers_is_specified_then_allow_them_all
skip_unless_rails_gte('5.2')
skip_unless_no_rails_or_rails_version_at_or_above(5.2)
skip_unless_minitest5_or_above

with_config(allow_all_headers: true) do
Expand Down Expand Up @@ -236,7 +236,7 @@ def test_the_use_of_attributes_include_as_an_allowlist
end

def test_the_use_of_attributes_exclude_as_a_blocklist
skip_unless_rails_gte('5.2')
skip_unless_no_rails_or_rails_version_at_or_above(5.2)
skip_unless_minitest5_or_above

excluded_header = :'request.headers.customHeader'
Expand Down

0 comments on commit aabe6c7

Please sign in to comment.