Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
RUBY-1454 Modify connection lookup for makara
Based on instacart/makara#59, there were perf issues in looking up the connection from the pool when on ActiveRecord 4.x using the makara adapter. While this was a problem with makara itself, @mnelson suggested alternate lookup code which works with makara and actually allocates less, so we're updating to use that.
- Loading branch information
82d2777
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @jasonrclark
82d2777
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem @mnelson. Note, though, that this is only on the
dev
branch and not in the 3.11.0 release that just went out. I noticed our deploy script was pushing more than justmaster
andrelease
out, which is why this showed up.You can certainly feel free to test against
dev
, and this change should show up for release in a new agent coming soon. Will ping you back for real when that happens.82d2777
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I'll continue working on a makara solution regardless of the rpm <> makara situation.