Skip to content

Commit

Permalink
Merge branch 'status_code_without_middleware_instrumentation' of gith…
Browse files Browse the repository at this point in the history
…ub.com:newrelic/newrelic-ruby-agent into status_code_without_middleware_instrumentation
  • Loading branch information
tannalynn committed Aug 22, 2023
2 parents 9620048 + d71461d commit 5dbc54e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@

## dev

Version <dev> allows the agent to record the http status code on a transaction when middleware instrumentation is disabled and fixes a bug in `NewRelic::Rack::AgentHooks.needed?.
Version <dev> allows the agent to record the http status code on a transaction when middleware instrumentation is disabled and fixes a bug in `NewRelic::Rack::AgentHooks.needed?`.


- **Feature: Transactions now report http status codes when middleware instrumentation is disabled**
Previously, if `disable_middleware_instrumentation` is set to true, the agent would not record the value of the response code on the transaction. This was due to the possibility that a middleware could be used that might alter the response, which would not be captured by the agent if the middleware instrumentation is disabled. However, based on customer feedback, the agent will now report the http status code on a transaction still when middleware instrumentation is disabled. [PR#2175](https://github.com/newrelic/newrelic-ruby-agent/pull/2175)
Previously, if `disable_middleware_instrumentation` is set to `true`, the agent would not record the value of the response code on the transaction. This was due to the possibility that a middleware could be used that might alter the response, which would not be captured by the agent if the middleware instrumentation is disabled. However, based on customer feedback, the agent will now report the http status code on a transaction still when middleware instrumentation is disabled. [PR#2175](https://github.com/newrelic/newrelic-ruby-agent/pull/2175)

- **Bugfix: Resolve inverted logic of `NewRelic::Rack::AgentHooks.needed?`**
Previously, `NewRelic::Rack::AgentHooks.needed?` was incorrectly using inverted logic. This has now been resolved. [PR#2175](https://github.com/newrelic/newrelic-ruby-agent/pull/2175)
Expand Down

0 comments on commit 5dbc54e

Please sign in to comment.