-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NR-199374 // Release script #2179
Conversation
8f97e56
to
bcc3d23
Compare
bcc3d23
to
9d080bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One straggler file that needs to be removed, but that it should be ready!
e695679
to
df1257e
Compare
Let's also disable the failing jobs so that they don't create a lot of noise. We can just comment out the follow lines: https://github.com/newrelic/newrelic-quickstarts/blob/release/.github/workflows/pr-merged.yml#L113-L165 |
feat: Clean up release utility feat: Release script
Co-authored-by: Alec Swanson <aswanson@newrelic.com>
8c06cbc
to
caab958
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing is maybe we should mention / document what the github token is used for and if there is any scenario in which you might need it?? just because i got tripped up on that one
This adds a new
release
script which can be invoked vianpm run release
oryarn release
. The script will run through a wizard to ensure that all required env vars are set and will target the selected environment for release. It relies on there being a merged PR fromrelease
->main
and requires the PR number.Testing
npm install
inutils
npm run release
TODO
Commit documentationDocs will live in Confluence and be written as a part of another ticket