Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR-199374 // Release script #2179

Merged
merged 9 commits into from
Jan 4, 2024
Merged

NR-199374 // Release script #2179

merged 9 commits into from
Jan 4, 2024

Conversation

d3caf
Copy link
Contributor

@d3caf d3caf commented Dec 28, 2023

This adds a new release script which can be invoked via npm run release or yarn release. The script will run through a wizard to ensure that all required env vars are set and will target the selected environment for release. It relies on there being a merged PR from release -> main and requires the PR number.

Testing

  • npm install in utils
  • Have a staging API token handy
  • npm run release
  • Can test against [DO NOT MERGE] Test new release script #2181 by providing it as the PR number when prompted. The script only uses the PR to determine which files changed and then runs mutations based on local files, so changes may not actually be accurate unless you've pulled the changes from 2181 locally.

TODO

  • Test against local NG
  • Commit documentation Docs will live in Confluence and be written as a part of another ticket

@d3caf d3caf force-pushed the andrew/NR-199374-release-script branch 2 times, most recently from 8f97e56 to bcc3d23 Compare January 3, 2024 19:00
utils/release.ts Dismissed Show dismissed Hide dismissed
@d3caf d3caf changed the base branch from release to main January 3, 2024 19:06
@d3caf d3caf force-pushed the andrew/NR-199374-release-script branch from bcc3d23 to 9d080bc Compare January 3, 2024 19:06
@d3caf d3caf marked this pull request as ready for review January 3, 2024 21:30
@d3caf d3caf requested review from a team, aswanson-nr and mickeyryan42 and removed request for a team January 3, 2024 21:30
Copy link
Contributor

@aswanson-nr aswanson-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One straggler file that needs to be removed, but that it should be ready!

utils/package-lock.json Outdated Show resolved Hide resolved
utils/release.ts Outdated Show resolved Hide resolved
@d3caf d3caf force-pushed the andrew/NR-199374-release-script branch from e695679 to df1257e Compare January 3, 2024 23:00
@aswanson-nr
Copy link
Contributor

Let's also disable the failing jobs so that they don't create a lot of noise. We can just comment out the follow lines: https://github.com/newrelic/newrelic-quickstarts/blob/release/.github/workflows/pr-merged.yml#L113-L165

@d3caf d3caf force-pushed the andrew/NR-199374-release-script branch from 8c06cbc to caab958 Compare January 3, 2024 23:14
Copy link
Contributor

@caylahamann caylahamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing is maybe we should mention / document what the github token is used for and if there is any scenario in which you might need it?? just because i got tripped up on that one

@d3caf d3caf merged commit 9bb7dfd into main Jan 4, 2024
16 checks passed
@d3caf d3caf deleted the andrew/NR-199374-release-script branch January 4, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants