Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product Partnerships] Added Amazon MediaTailor Entity #2097

Merged
merged 8 commits into from
Oct 6, 2023
Merged

[Product Partnerships] Added Amazon MediaTailor Entity #2097

merged 8 commits into from
Oct 6, 2023

Conversation

SuruchiSaboo
Copy link
Contributor

[Product Partnerships] Added Amazon MediaTailor Entity

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

@SuruchiSaboo SuruchiSaboo changed the title [Product Partnerships] Added Amazon MediaTailor Entity [DO NOT MERGE] [Product Partnerships] Added Amazon MediaTailor Entity Oct 4, 2023
- elemental media tailor
- aws elemental mediatailor
alertPolicies:
- aws-elemental-mediatailor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation of this quickstart is failing on locating an alert policy named aws-elemental-mediatailor. The alert policy added in this PR is named amazon-mediatailor. Lets resolve this by renaming that alert policy directory to aws-elemental-mediatailor like the dashboard and quickstart

description: |
Monitor AWS Elemental MediaTailor by connecting AWS to New Relic.
url: >-
https://docs.newrelic.com/docs/infrastructure/amazon-integrations/aws-integrations-list/aws-elemental-mediatailor-monitoring-integration/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuruchiSaboo SuruchiSaboo changed the title [DO NOT MERGE] [Product Partnerships] Added Amazon MediaTailor Entity [Product Partnerships] Added Amazon MediaTailor Entity Oct 5, 2023
@MichelLosier MichelLosier self-requested a review October 5, 2023 17:09
Copy link
Contributor

@MichelLosier MichelLosier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@MichelLosier MichelLosier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichelLosier MichelLosier merged commit 0fd06c7 into newrelic:main Oct 6, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants