Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new mux quickstart #1763

Merged
merged 16 commits into from
Jul 17, 2023
Merged

feat: new mux quickstart #1763

merged 16 commits into from
Jul 17, 2023

Conversation

jcountsNR
Copy link
Contributor

@jcountsNR jcountsNR commented May 3, 2023

Summary

New Mux quickstart. Includes Dashboard, data source, and quickstart files. Creating as a draft until the docs are published.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@github-actions
Copy link

github-actions bot commented May 3, 2023

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

@github-actions
Copy link

github-actions bot commented May 3, 2023

Click the link(s) below to view a preview of your changes on newrelic.com/instant-observability

- mux-video
- golang/mux

@jcountsNR jcountsNR marked this pull request as ready for review May 3, 2023 19:32
@jcountsNR jcountsNR requested a review from seemantk as a code owner May 3, 2023 19:32
aswanson-nr
aswanson-nr previously approved these changes May 9, 2023
@jcountsNR
Copy link
Contributor Author

@aswanson-nr has this been merged yet? I'm thinking we should hold off for just a bit, I got some feedback from Mux and they want to make a few changes to the dashboard and text here.

@github-actions
Copy link

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

@github-actions github-actions bot added the stale label May 31, 2023
@aswanson-nr
Copy link
Contributor

Not stale! going to remove that label.
@jcountsNR this appears to be ready to go, but there's a test.json dashboard. If that's intended to be part of this quickstart, could adjust the name to be more descriptive?

@aswanson-nr aswanson-nr removed the stale label May 31, 2023
@github-actions
Copy link

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

@github-actions github-actions bot added the stale label Jun 15, 2023
@brammerl brammerl removed the stale label Jun 15, 2023
@brammerl
Copy link
Contributor

Removing the stale logo. Waiting on JRCounts to get clearance before publishing.

@github-actions
Copy link

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

@github-actions github-actions bot added the stale label Jun 30, 2023
@jcountsNR
Copy link
Contributor Author

@aswanson-nr / @seemantk - Updating this one. It should be ready to be reviewed in the next cycle!

dashboards/test/test.json Outdated Show resolved Hide resolved
@brammerl brammerl merged commit 7296c6a into main Jul 17, 2023
3 checks passed
@brammerl brammerl deleted the mux branch July 17, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants