Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django test cleanup--WIP #854

Closed
wants to merge 34 commits into from
Closed

Django test cleanup--WIP #854

wants to merge 34 commits into from

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Jun 27, 2023

This PR updates the existing Django instrumentation by adding instrumentation for newer functions that have been added to Django's library while excluding the older functions (that are outside of New Relic's support window) from the coverage analysis.

@mergify mergify bot removed the merge-conflicts label Jun 27, 2023
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 5.02s
✅ PYTHON black 4 0 0 1.42s
✅ PYTHON flake8 4 0 0.72s
✅ PYTHON isort 4 0 0 0.22s
✅ PYTHON pylint 4 0 7.52s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Merging #854 (54f1e0c) into main (56ea815) will decrease coverage by 5.72%.
The diff coverage is 0.68%.

❗ Current head 54f1e0c differs from pull request most recent head 74893cc. Consider uploading reports for the commit 74893cc to get more accurate results

@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
- Coverage   81.22%   75.51%   -5.72%     
==========================================
  Files         185      185              
  Lines       18518    18503      -15     
  Branches     3210     3206       -4     
==========================================
- Hits        15042    13973    -1069     
- Misses       2593     3645    +1052     
- Partials      883      885       +2     
Files Changed Coverage Δ
newrelic/hooks/framework_django.py 0.00% <0.00%> (-73.42%) ⬇️
newrelic/config.py 70.93% <100.00%> (ø)

... and 54 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot removed the tests-failing label Jun 27, 2023
@lrafeei lrafeei changed the title Django test cleanup/coverage increase Django test cleanup Jun 28, 2023
@lrafeei lrafeei changed the title Django test cleanup Django test cleanup--WIP Jun 30, 2023
@mergify mergify bot removed the merge-conflicts label Jul 12, 2023
@mergify mergify bot removed the tests-failing label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants