Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Attributes #1033

Merged
merged 11 commits into from
Jan 12, 2024
Merged

Logging Attributes #1033

merged 11 commits into from
Jan 12, 2024

Commits on Dec 11, 2023

  1. Log Forwarding User Attributes (#682)

    * Add context data setting
    
    Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>
    Co-authored-by: Hannah Stepanek <hmstepanek@users.noreply.github.com>
    Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com>
    
    * Update record_log_event signature with attributes
    
    * Logging attributes initial implementation
    
    * Fix settings attribute error
    
    * Update logging instrumentation with attributes
    
    * Update log handler API
    
    * Add loguru support for extra attrs
    
    * Add more explicit messaging to validator
    
    * Expanding testing for record_log_event
    
    * Expand record log event testing
    
    * Fix settings typo
    
    * Remove missing loguru attributes from test
    
    * Adjust safe log attr encoding
    
    * Correct py2 issues
    
    * Fix missing record attrs in logging.
    
    Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>
    Co-authored-by: Hannah Stepanek <hmstepanek@users.noreply.github.com>
    Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com>
    Co-authored-by: Hannah Stepanek <hstepanek@newrelic.com>
    5 people committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    1d43944 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Configuration menu
    Copy the full SHA
    364fd7b View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Log Attribute Filtering (#1008)

    * Expand validator for log events
    
    * Add settings for context data filtering
    
    * Add attribute filtering for log events
    
    * Linting
    
    * Apply suggestions from code review
    
    * Remove none check on attributes
    TimPansino authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    fb1f47d View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Squashed commit of the following:

    commit 3962f54
    Author: Uma Annamalai <uannamalai@newrelic.com>
    Date:   Thu Jan 4 12:50:58 2024 -0800
    
        Remove case sensitive check in ASGIBrowserMiddleware check. (#1017)
    
        * Remove case sensitive check in should_insert_html.
    
        * [Mega-Linter] Apply linters fixes
    
        * Remove header decoding.
    
        ---------
    
        Co-authored-by: umaannamalai <umaannamalai@users.noreply.github.com>
    
    commit c3314ae
    Author: Lalleh Rafeei <84813886+lrafeei@users.noreply.github.com>
    Date:   Tue Jan 2 17:17:20 2024 -0800
    
        Temporarily pin hypercorn version in tests (#1021)
    
        * Temporarily pin hypercorn to <0.16
    
        * Temporarily pin hypercorn to <0.16
    
        * Add comment to tox.ini
    
        ---------
    
        Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
    
    commit 1357145
    Author: Uma Annamalai <uannamalai@newrelic.com>
    Date:   Tue Jan 2 16:17:08 2024 -0800
    
        Drop py27 from memcache testing. (#1018)
    
    commit 23f969f
    Author: Timothy Pansino <11214426+TimPansino@users.noreply.github.com>
    Date:   Wed Dec 20 17:01:50 2023 -0800
    
        Nonced CSP Support (#998)
    
        * Add nonce to CSP in browser agent
    
        * Adjust nonce position
    
        * Add testing for browser timing nonces
    
    commit 8bfd2b7
    Author: Uma Annamalai <uannamalai@newrelic.com>
    Date:   Mon Dec 18 13:58:10 2023 -0800
    
        Remove RPM config workflow. (#1007)
    TimPansino committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    d98d5f2 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Add Dictionary Log Message Support (#1014)

    * Add tests for logging's json logging
    
    * Upgrade record_log_event to handle dict logging
    
    * Update logging to capture dict messages
    
    * Add attributes for dict log messages
    
    * Implementation of JSON message filtering
    
    * Correct attributes only log behavior
    
    * Testing for logging attributes
    
    * Add logging context test for py2
    
    * Logically separate attribute tests
    
    * Clean out imports
    
    * Fix failing tests
    
    * Remove logging instrumentation changes for new PR
    
    * Add test for record log event edge cases
    
    * Update record_log_event for code review
    
    * Fix truncation
    
    * Move safe_json_encode back to api.log as it's unused elsewhere
    
    * Black formatting
    
    * Add missing import
    
    * Fixup warning message
    
    ---------
    
    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
    TimPansino and mergify[bot] authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    9cd6af2 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Logging Attribute Instrumentation (#1015)

    * Add tests for logging's json logging
    
    * Upgrade record_log_event to handle dict logging
    
    * Update logging to capture dict messages
    
    * Add attributes for dict log messages
    
    * Implementation of JSON message filtering
    
    * Correct attributes only log behavior
    
    * Testing for logging attributes
    
    * Add logging context test for py2
    
    * Logically separate attribute tests
    
    * Clean out imports
    
    * Fix failing tests
    
    * Linting
    
    * Ignore path hash
    
    * Fix linter errors
    
    * Fix linting issues
    
    * Apply suggestions from code review
    TimPansino authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    db15109 View commit details
    Browse the repository at this point in the history
  2. StructLog Attribute Instrumentation (#1026)

    * Add tests for logging's json logging
    
    * Upgrade record_log_event to handle dict logging
    
    * Update logging to capture dict messages
    
    * Add attributes for dict log messages
    
    * Implementation of JSON message filtering
    
    * Correct attributes only log behavior
    
    * Testing for logging attributes
    
    * Add logging context test for py2
    
    * Logically separate attribute tests
    
    * Clean out imports
    
    * Fix failing tests
    
    * Structlog cleanup
    
    * Attempting list instrumentation
    
    * Structlog attributes support
    
    Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com>
    Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>
    
    * Remove other frameworks changes
    
    * Bump tests
    
    * Change cache to lru cache
    
    * Linting
    
    * Remove TODO
    
    * Remove unnecessary check
    
    ---------
    
    Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com>
    Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>
    3 people authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    f60c29f View commit details
    Browse the repository at this point in the history
  3. Loguru Attribute Instrumentation (#1025)

    * Add tests for logging's json logging
    
    * Upgrade record_log_event to handle dict logging
    
    * Update logging to capture dict messages
    
    * Add attributes for dict log messages
    
    * Implementation of JSON message filtering
    
    * Correct attributes only log behavior
    
    * Testing for logging attributes
    
    * Add logging context test for py2
    
    * Logically separate attribute tests
    
    * Clean out imports
    
    * Fix failing tests
    
    * Structlog cleanup
    
    * Attempting list instrumentation
    
    * Structlog attributes support
    
    Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com>
    Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>
    
    * Loguru instrumentation refactor
    
    * New attribute testing
    
    * Move exception settings
    
    * Clean up testing
    
    * Remove unneeded option
    
    * Remove other framework changes
    
    * [Mega-Linter] Apply linters fixes
    
    * Bump tests
    
    ---------
    
    Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com>
    Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>
    Co-authored-by: TimPansino <TimPansino@users.noreply.github.com>
    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
    5 people authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    92cca1e View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Configuration menu
    Copy the full SHA
    d301c17 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0dc4f7b View commit details
    Browse the repository at this point in the history
  3. Update web_transaction.py

    TimPansino authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    d114ebe View commit details
    Browse the repository at this point in the history