Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axiom): externalCallCount should be added to the txn not just the error #1006

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

zsistla
Copy link
Contributor

@zsistla zsistla commented Jan 8, 2025

No description provided.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Jan 8, 2025

Test Suite Status Result
Multiverse 8/8 passing
SOAK 72/72 passing

lavarou
lavarou previously approved these changes Jan 8, 2025
Copy link
Member

@lavarou lavarou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hahuja2 hahuja2 self-requested a review January 8, 2025 21:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (f26aead) to head (28b7e59).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1006      +/-   ##
==========================================
- Coverage   78.61%   78.04%   -0.57%     
==========================================
  Files         196      196              
  Lines       27069    27105      +36     
==========================================
- Hits        21280    21155     -125     
- Misses       5789     5950     +161     
Flag Coverage Δ
agent-for-php-7.2 78.04% <100.00%> (-0.59%) ⬇️
agent-for-php-7.3 78.05% <100.00%> (-0.59%) ⬇️
agent-for-php-7.4 77.76% <100.00%> (-0.59%) ⬇️
agent-for-php-8.0 77.13% <100.00%> (-1.24%) ⬇️
agent-for-php-8.1 77.79% <100.00%> (-0.56%) ⬇️
agent-for-php-8.2 77.38% <100.00%> (-0.56%) ⬇️
agent-for-php-8.3 77.38% <100.00%> (-0.56%) ⬇️
agent-for-php-8.4 77.40% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zsistla zsistla added this to the next-release milestone Jan 8, 2025
@zsistla zsistla merged commit 8a73dde into dev Jan 9, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants