-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove emoji and update moto #296
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
==========================================
- Coverage 75.44% 75.41% -0.04%
==========================================
Files 18 18
Lines 1572 1570 -2
==========================================
- Hits 1186 1184 -2
Misses 386 386 ☔ View full report in Codecov by Sentry. |
This seems fine to me since this is a CLI tool, and I would expect customers would be less likely to end up with huge dependency conflicts considering they can make an isolated virtual environment for the CLI. (For any customers reading this, pipx is a common tool for that.) If we have issues in the future about the requirements being too strict we may want to drop down to pinning to minor versions instead of fully pinning the version number. |
a5f0bad
to
8f6bb6c
Compare
Updated the PR, to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
To resolve the issue #215, removed the package
emoji
emoji
as it has caused couple of issues in the past, for instance - TypeError: emojize() got an unexpected keyword argument 'use_aliases' #215 & Latest emoji package release breaks new-relic-cli installation #281moto
, the package has breaking changes here, so updated the tests to use the latestmock_aws
for mockingsetuptools
, as latestsetuptools
has deprecated use of tests.Readme
to run tests usingpytest
.