Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove emoji and update moto #296

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

chaudharysaket
Copy link
Collaborator

@chaudharysaket chaudharysaket commented Aug 21, 2024

To resolve the issue #215, removed the package emoji

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.41%. Comparing base (d84fb54) to head (830fa15).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   75.44%   75.41%   -0.04%     
==========================================
  Files          18       18              
  Lines        1572     1570       -2     
==========================================
- Hits         1186     1184       -2     
  Misses        386      386              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimPansino
Copy link
Contributor

This seems fine to me since this is a CLI tool, and I would expect customers would be less likely to end up with huge dependency conflicts considering they can make an isolated virtual environment for the CLI. (For any customers reading this, pipx is a common tool for that.)

If we have issues in the future about the requirements being too strict we may want to drop down to pinning to minor versions instead of fully pinning the version number.

TimPansino
TimPansino previously approved these changes Aug 21, 2024
@chaudharysaket
Copy link
Collaborator Author

This seems fine to me since this is a CLI tool, and I would expect customers would be less likely to end up with huge dependency conflicts considering they can make an isolated virtual environment for the CLI. (For any customers reading this, pipx is a common tool for that.)

If we have issues in the future about the requirements being too strict we may want to drop down to pinning to minor versions instead of fully pinning the version number.

Updated the PR, to remove the emoji package, such that we don't have to drop down to pinning in future.

@chaudharysaket chaudharysaket changed the title pin package versions remove emoji and update moto Aug 22, 2024
Copy link
Contributor

@umaannamalai umaannamalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@chaudharysaket chaudharysaket merged commit 83fbaaa into newrelic:main Aug 26, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants