impelementation jakarta jax-rs #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jakarta EE 8 doesn't change functionality or package names, it only publishes the artifacts under new jakarta maven coordinates.
In theory our instrumentation should still compile and function properly when updated to use the jakarta 8 dependencies as the package names and code that we instrument haven't changed.
For existing instrumentation that has dependencies on the various javax.* packages we'll need to update them to use the Jakarta 8 EE version of the dependency and verify that the modules still compile and that all tests still pass.
jax-rs-1.0
Dependencies to use:
// https://mvnrepository.com/artifact/jakarta.ws.rs/jakarta.ws.rs-api
implementation 'jakarta.ws.rs:jakarta.ws.rs-api:3.1.0'
https://mvnrepository.com/artifact/jakarta.ws.rs/jakarta.ws.rs-api/3.1.0
Success Criteria
Existing instrumentation module successfully compiles and passes tests when using the Jakarta EE 8 maven artifacts.