XML extensions to mirror class annotations trace lambda and trace by return type behaviour #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDownes
changed the title
meiao
changed the title
meiao
requested changes
Jun 22, 2021
...ent/src/main/java/com/newrelic/agent/instrumentation/methodmatchers/LambdaMethodMatcher.java
Outdated
Show resolved
Hide resolved
...ent/src/main/java/com/newrelic/agent/instrumentation/methodmatchers/LambdaMethodMatcher.java
Outdated
Show resolved
Hide resolved
newrelic-agent/src/main/java/com/newrelic/agent/extension/beans/Extension.java
Outdated
Show resolved
Hide resolved
Move to boolean to prevent unboxing. Make constant for access code.
meiao
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added two new XML properties to provide the ability to apply logic similar to the new class annotations TraceLambda and TraceByReturnType using XML.
Testing
Added unit tests to cover XML TraceLambda TraceByReturnType usage scenarios.
Deploy updated agent locally and reviewed traces in New Relic One.
Checks
[X] Are your contributions backwards compatible with relevant frameworks and APIs? Yes
[X] Does your code contain any breaking changes? Please describe. No
[X] Does your code introduce any new dependencies? Please describe. No