Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Firehose SDK Instrumentation #2149

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

obenkenobi
Copy link
Contributor

Overview

Adds instrumentation for firehose. Every operation with firehose will include the following attributes:

  • cloud.platform: which will contain the string aws_kinesis_delivery_streams
  • cloud.resource_id, which will contain an ARN in the format arn:aws:firehose:${region}:${accountId}:deliverystream/${streamName}. If it is not possible to get the full ARN, the property will not be set.

All firehose spans/traces are named in the formats:

  • Firehose/{operationName} (e.g. Firehose/listDeliveryStreams)
  • Firehose/{operationName}/{deliveryStreamName} (e.g. Firehose/putRecord/someStream)

Related Github Issue

#2070

@obenkenobi obenkenobi changed the title Add AWS Firehose Instrumentation Add AWS Firehose SDK Instrumentation Nov 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.70%. Comparing base (1e56ef1) to head (7dc3f84).
Report is 50 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2149      +/-   ##
============================================
- Coverage     70.70%   70.70%   -0.01%     
- Complexity     9987    10001      +14     
============================================
  Files           841      842       +1     
  Lines         40290    40348      +58     
  Branches       6107     6115       +8     
============================================
+ Hits          28489    28527      +38     
- Misses         9061     9072      +11     
- Partials       2740     2749       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meiao meiao self-requested a review December 2, 2024 17:45
@obenkenobi obenkenobi merged commit edd9fb5 into main Dec 17, 2024
107 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants