Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB: populate cloud.resource_id #2113

Merged
merged 3 commits into from
Oct 30, 2024
Merged

DynamoDB: populate cloud.resource_id #2113

merged 3 commits into from
Oct 30, 2024

Conversation

meiao
Copy link
Contributor

@meiao meiao commented Oct 29, 2024

Overview

Changes to the DynamoDB instrumentation to populate the cloud.resource_id attribute.
This attribute will allow an instrumented DynamoDB table to be linked to an APM that calls it.

Related Github Issue

Fixes #1802

Checks

  • Your contributions are backwards compatible with relevant frameworks and APIs.
  • Your code does not contain any breaking changes. Otherwise please describe.
  • Your code does not introduce any new dependencies. Otherwise please describe.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.68%. Comparing base (ec234dd) to head (d9d494f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2113      +/-   ##
============================================
+ Coverage     70.66%   70.68%   +0.02%     
- Complexity     9964     9967       +3     
============================================
  Files           840      840              
  Lines         40251    40252       +1     
  Branches       6106     6106              
============================================
+ Hits          28442    28452      +10     
+ Misses         9065     9060       -5     
+ Partials       2744     2740       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meiao meiao merged commit ca7cf3e into main Oct 30, 2024
111 checks passed
@meiao meiao deleted the dynamodb branch October 30, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add span attribute support for AWS_DYNAMO_DB_TABLE
3 participants