Refactor vertx-web to weave Http2ServerConnection #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleonenriqueta
approved these changes
Jun 26, 2024
meiao
approved these changes
Jun 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1959 +/- ##
============================================
- Coverage 70.61% 70.59% -0.02%
- Complexity 9859 9860 +1
============================================
Files 827 827
Lines 39857 39857
Branches 6068 6068
============================================
- Hits 28144 28138 -6
- Misses 8983 8991 +8
+ Partials 2730 2728 -2 ☔ View full report in Codecov by Sentry. |
|
Related to #1799 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a gap in the
vertx-webinstrumentation where transactions weren't getting started when handling HTTP/2 requests.Weaves the
io.vertx.core.http.impl.HttpServerConnectioninterface instead of just theHttp1xServerConnectionimplementation. This results inHttp1xServerConnectionbeing weaved as well as the previously un-instrumentedHttp2ServerConnectionimplementation.