Pr 1454 #1565
Merged
Pr 1454 #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1565 +/- ##
=============================================
+ Coverage 60.00% 70.59% +10.58%
- Complexity 8543 9791 +1248
=============================================
Files 862 817 -45
Lines 40762 39489 -1273
Branches 6083 5995 -88
=============================================
+ Hits 24461 27877 +3416
+ Misses 13866 8904 -4962
- Partials 2435 2708 +273 see 290 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jasonjkeller
commented
Oct 25, 2023
| @@ -41,7 +44,15 @@ public static ParseAndValidateResult parse(ExecutionInput executionInput) { | |||
| return result; | |||
| } | |||
|
|
|||
| public static List<ValidationError> validate(GraphQLSchema graphQLSchema, Document parsedDocument) { | |||
| public static List<ValidationError> validate(GraphQLSchema graphQLSchema, Document parsedDocument, Predicate<Class<?>> rulePredicate, Locale locale) { | |||
There was a problem hiding this comment.
The main change made to the customer's PR was instrumenting the correct signatures of the validate method so that error info is properly captured.
jtduffy
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #1454 and addresses several issues with the original PR.
Simple transaction showing the
graphql-java-21.0instrumentation working: