Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#NEWRELIC-6527 guard lettuce npe #1204

Merged
merged 1 commit into from
Apr 14, 2023
Merged

#NEWRELIC-6527 guard lettuce npe #1204

merged 1 commit into from
Apr 14, 2023

Conversation

tbradellis
Copy link
Contributor

@tbradellis tbradellis commented Apr 11, 2023 •
edited
Loading

Overview

Reported NPE on newrelic java agent 7.9 and 7.11 in the lettuce instrumentation

java.lang.NullPointerException
at com.nr.lettuce5.instrumentation.NRHolder.end(NRHolder.java:59)
at com.nr.lettuce5.instrumentation.NRSignalTypeConsumer.accept(NRSignalTypeConsumer.java:24)
at com.nr.lettuce5.instrumentation.NRSignalTypeConsumer.accept(NRSignalTypeConsumer.java:13)
}}{{at reactor.core.publisher.FluxDoFinally$DoFinallySubscriber.runFinally(FluxDoFinally.java:156)
}}{{at reactor.core.publisher.FluxDoFinally$DoFinallySubscriber.onError(FluxDoFinally.java:132)

Related Github Issue

https://issues.newrelic.com/browse/NEWRELIC-6527

Checks

[ ] Are your contributions backwards compatible with relevant frameworks and APIs?
[ ] Does your code contain any breaking changes? Please describe.
[ ] Does your code introduce any new dependencies? Please describe.

@tbradellis tbradellis force-pushed the npe-guard-lettuce-datastoreparams branch from c448372 to 90e2830 Compare April 11, 2023 13:29
@workato-integration workato-integration bot mentioned this pull request Apr 11, 2023
Closed
@tbradellis
guard lettuce npe
55dee5a 
remove incorrect comment
@tbradellis tbradellis force-pushed the npe-guard-lettuce-datastoreparams branch from 90e2830 to 55dee5a Compare April 13, 2023 17:02
@tbradellis tbradellis merged commit f559a15 into main Apr 14, 2023
@tbradellis tbradellis deleted the npe-guard-lettuce-datastoreparams branch April 14, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtduffy jtduffy jtduffy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbradellis @jtduffy