fix tomcat 10 jakarta naming #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where we miss reporting an Exception stack trace. This surfaced as a "Spring Boot 3" issue, but it is in reality an issue with our tomcat 10 instrumentation. Tomcat 10 was migrated to all Jakarta naming packages. There was a key string we use that did not update to the correct jakarta named package that we expect (was javax...)
Essentially the exception thrown in the Spring Boot controller bubbles up to the
DispatcherServlet extends FrameworkServlet, which is where we would report this exception. Because the naming was wrong, the transactionData throwable is set to null and we only show the status 500.And just for completeness, I updated the agent package names to reflect they are in our tomcat10 module vs tomcat7
This screenshot demonstrates
Overview
Describe the changes present in the pull request
Related Github Issue
Include a link to the related GitHub issue, if applicable
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks
[ ] Are your contributions backwards compatible with relevant frameworks and APIs?
[ ] Does your code contain any breaking changes? Please describe.
[ ] Does your code introduce any new dependencies? Please describe.