Fix jdk11 http client so that segments don't time out

[jasonjkeller]

Fixes a bug that would cause a segment timeout in the JDK 11 HTTP client instrumentation. The bug would occur whenever the synchronous HttpClient.send(...) method was invoked and any exception other than a ConnectException was thrown.

If an exception occurred here we would call handleConnectException:

    @Trace
    public <T> HttpResponse<T> send(HttpRequest req, HttpResponse.BodyHandler<T> responseHandler)
            throws IOException, InterruptedException {
        URI uri = req.uri();
        Segment segment = startSegment(uri);
        HttpResponse<T> response;
        try {
            response = Weaver.callOriginal();
            if (segment == null) {
                return response;
            }
        } catch (Exception e) {
            handleConnectException(e, req, segment);
            throw e;
        }
        processResponse(response, segment);
        return response;
    }

If the exception was a ConnectException we would properly report it and end the segment but if it was any other exception type it only gets reported without actually ending the segment.

    public static void handleConnectException(Exception e, HttpRequest request, Segment segment){
        if (request.uri() != null) {
            if (throwableIsConnectException(e)) {
                reportUnknownHostExternal(segment);
            } else {
                NewRelic.noticeError(e);
                // FIXME we should be calling segment.end() in this case as well
            }
        }
    }

This would result in a segment for the external call hitting the 10 minute segment timeout limit and being truncated:

After expiring the segment properly the segment completes in milliseconds and is no longer truncated:

[tbradellis]

Looks pretty straight forward to me!