Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java Agent - FY25Q1 - Enhance Entity Relationships #47

Closed
pontello opened this issue Sep 11, 2020 · 3 comments
Closed

Java Agent - FY25Q1 - Enhance Entity Relationships #47

pontello opened this issue Sep 11, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@pontello
Copy link

Java Agent 5.13.0 added support for setting custom attributes if you use TracedMethod.

I wish I could do the same when using Segments. 😃
@tspring
Copy link
Contributor

tspring commented Sep 15, 2020

Thanks for the suggestion. Would adding attributes to the underlying tracer via segment.getTransaction().getTracedMethod() be sufficient for your use case?

@pontello
Copy link
Author

Hi @tspring ,

Unfortunately no, my use case is a custom instrumentation for an async external call using native java 11 HttpClient. The method itself doesn't hang because it is an external async call.

Thanks

@tspring tspring added the enhancement New feature or request label Sep 17, 2020
tspring added a commit that referenced this issue Sep 20, 2020
@tspring
#47 Add custom attributes to async segment tracers
13cb0d9
@tspring
Copy link
Contributor

tspring commented Sep 20, 2020

@pontello I added support for custom attributes to Spans via the Segment API, if you'd like to give it a try and let me know if it solves your issue. Thanks again! #67

@breedx-nr breedx-nr mentioned this issue Sep 23, 2020
Merged
@tspring tspring closed this as completed Sep 23, 2020
@workato-integration workato-integration bot changed the title Support custom attributes for segments Java Agent - FY25Q2 - Enhance Entity Relationships Feb 26, 2024
@workato-integration workato-integration bot changed the title Java Agent - FY25Q2 - Enhance Entity Relationships Java Agent - FY25Q1 - Enhance Entity Relationships Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Java Engineering Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tspring @pontello