Fix path for signing keys #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuqtran88
approved these changes
Jan 4, 2022
nr-ahemsath
added a commit
that referenced
this pull request
Jan 18, 2022
* Updating linux package build and test assets to use net6.0. work in progress * Make sure that we're installing the correct architecture agent - this is working now * Update smoke test to net6.0 * Remove stray file that got checked in, and update gitignore * Updating DebugDockerfile to ubuntu-20.04, newer clang/llvm and .net 6.0 * fix correctly report whether SSC is enabled. (#866) * work in progress * Fix path for signing keys (#867) * Update Changelog (#868) * Update Changelog * add release date. * allow NewRelicQueryName to be specified for SQL, with unit tests (#799) * allow NewRelicSegmentName to be specified for SQL, with unit tests * Add Changelog message * change NewRelicSegmentName to NewRelicQueryName * build container builds and profiler builds * Working (?) DebugDockerfile * build on ubuntu 18.04 with llvm 7 and coreclr 3.1 * CHANGELOG updates (#873) * Remove unused Linux profiler test containers/scripts/code * Fix issue where GC metrics were not being captured for .NET6 (#874) * Fix issue with GUID of dotnet event source changing for .net core applications in .NET 6 * Update integration tests to check the GC gen0 metric.. not happy with the amount of delay this adds, but this is what is working * Update integration tests to not add 1 hundred million seconds to all the performance tests * Context, context, context * Update changelog * Only run new assertion if this test case expects there to be GC metrics * Refactor (to avoid repetition) and add core 3.1 test case * 2.2->2.1; remove 2.2 console test app build * Re-enable .net core 2.2 ConsoleMF base class due to unbounded integration test usage Co-authored-by: Alex Hemsath <ahemsath@newrelic.com> Co-authored-by: Vu Tran <56414817+vuqtran88@users.noreply.github.com> Co-authored-by: kevinpohlmeier <kevinp@dpath.com> Co-authored-by: Josh Coleman <83677148+JcolemanNR@users.noreply.github.com> Co-authored-by: Basil Abusamrah <tehbio@gmail.com>
tehbio
added a commit
that referenced
this pull request
Jan 27, 2022
* Added CoreCLR flag. * Automatically detect CLR type. (#870) * Better naming. * Add logic to detect CoreCLR during the profiler Initialization. * combine ShouldInstrument methods. * Move _systemCalls initialization to beginning of the Initialize(). Manually set the New Relic home and install path env variables after detecting the clr type. * fix build failure in Linux. * Refactored SystemCalls. Co-authored-by: Basil Abusamrah <tehbio@gmail.com> * One CorProfilerCallbackImpl for NetCore and Framework (#876) * Better naming. * Add logic to detect CoreCLR during the profiler Initialization. * combine ShouldInstrument methods. * Move _systemCalls initialization to beginning of the Initialize(). Manually set the New Relic home and install path env variables after detecting the clr type. * Merges ModuleLoadFinished() implementation. * combines different implementation of ConfigureEventMask(), OverrideEventMask() and GetRuntimeExtensionsDirectoryName() into ones. * removes CoreCLRCorProfilerCallbackImpl.h and FrameworkCorProfilerCallbackImpl.h * fix build failure in Linux. * disable code that uses _moduleInjector in Linux environment. * fix a mistake from merging. * removes unnecessary include. removes unnecessary _systemCalls initialization. refactoring. * Refresh profiler build Dockerfiles (#877) * Updating linux package build and test assets to use net6.0. work in progress * Make sure that we're installing the correct architecture agent - this is working now * Update smoke test to net6.0 * Remove stray file that got checked in, and update gitignore * Updating DebugDockerfile to ubuntu-20.04, newer clang/llvm and .net 6.0 * fix correctly report whether SSC is enabled. (#866) * work in progress * Fix path for signing keys (#867) * Update Changelog (#868) * Update Changelog * add release date. * allow NewRelicQueryName to be specified for SQL, with unit tests (#799) * allow NewRelicSegmentName to be specified for SQL, with unit tests * Add Changelog message * change NewRelicSegmentName to NewRelicQueryName * build container builds and profiler builds * Working (?) DebugDockerfile * build on ubuntu 18.04 with llvm 7 and coreclr 3.1 * CHANGELOG updates (#873) * Remove unused Linux profiler test containers/scripts/code * Fix issue where GC metrics were not being captured for .NET6 (#874) * Fix issue with GUID of dotnet event source changing for .net core applications in .NET 6 * Update integration tests to check the GC gen0 metric.. not happy with the amount of delay this adds, but this is what is working * Update integration tests to not add 1 hundred million seconds to all the performance tests * Context, context, context * Update changelog * Only run new assertion if this test case expects there to be GC metrics * Refactor (to avoid repetition) and add core 3.1 test case * 2.2->2.1; remove 2.2 console test app build * Re-enable .net core 2.2 ConsoleMF base class due to unbounded integration test usage Co-authored-by: Alex Hemsath <ahemsath@newrelic.com> Co-authored-by: Vu Tran <56414817+vuqtran88@users.noreply.github.com> Co-authored-by: kevinpohlmeier <kevinp@dpath.com> Co-authored-by: Josh Coleman <83677148+JcolemanNR@users.noreply.github.com> Co-authored-by: Basil Abusamrah <tehbio@gmail.com> * refactoring ShouldInstrument method. (#881) * Remove unnecessary GUID check (#882) * Removed now unnecessary guid check. * Refactor to reduce code duplication. * Added new guid configuration integration test. * Minor documentation update. * Fixt indent. * Included new integration tests in CI, and re-alphabetized them. * Removed unused constants. * More clarity to readme. * Better test comments. * Added new pre-build dev binaries. Co-authored-by: Vu Tran <56414817+vuqtran88@users.noreply.github.com> Co-authored-by: Alex Hemsath <57361211+nr-ahemsath@users.noreply.github.com> Co-authored-by: kevinpohlmeier <kevinp@dpath.com> Co-authored-by: Josh Coleman <83677148+JcolemanNR@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to fix a path in the agent deploy workflow based on the changes in this previous PR: https://github.com/newrelic/newrelic-dotnet-agent/pull/862/files
I tested this by running a test deploy and it succeeded: https://github.com/newrelic/newrelic-dotnet-agent/runs/4707961644?check_suite_focus=true