Report total physical system memory on Linux #855
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #36.
Total system memory will now be reported by .NET core agents running on Linux systems. The agent reads
/proc/meminfo
and pulls out theMemTotal
value.Regarding testing: I considered adding a unit test for this, but the only real logic is the regex parsing of the
MemTotal: 12345 kB
line, and so a unit test using mock/fake/proc/meminfo
data would just be testing that the regex works or doesn't. I can still add a unit test like this if desired; some refactoring would be required to make the method in question testable. We don't have any existing integration tests for this feature of the agent, and an integration test seems too heavyweight for this.I did test this change manually on Ubuntu 20.04 and verified that the total physical memory was being sent in the utilization payload.
Author Checklist
Reviewer Checklist