Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux ARM64 Support #768

Merged
merged 13 commits into from
Oct 26, 2021
Merged

Add Linux ARM64 Support #768

merged 13 commits into from
Oct 26, 2021

Conversation

tehbio
Copy link
Contributor

@tehbio tehbio commented Oct 25, 2021

Description

Adds Linux ARM64 support to the Agent, including building and testing.

List of PRs that made up this feature branch can be found under the milestone here.

Author Checklist

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)
  • Review Changelog

jaffinito and others added 12 commits October 3, 2021 19:30
* Adds new profiler build job for arm64
Updates existing linuc job name to callout out arch
Updates conditionals to match new job names
Updates _profilerBuild deletion list to include new paths

* Updates build_functions.ps1 to support new folder names

* Removed -march from CMAKELIST
* Builds but some int tests fail locally; want to test in GHA

* Multi-targeted integration test project

* Conditional inclusion of WCF project

* Various Linux compatibility fixes, WIP

* Linux debugging, WIP, will not work on Windows

* Dynamic detection of Windows vs. Linux

* Added commands to remove expired cert. (#748)

* More windows/linux differences

* Make IsLinux a property

* Update mongodb tests (#747)

* Updates MongDb driver to v2.13.1.
Adds CoreIndexManger related tests to test against a net core test application.
Refactors tests.

* fixes failed test endpoints due to incorrectly exercises mongodb apis.

* Expands AsyncCursorsTests tests to NetCore test application.

* Expands IndexManagerTests tests to the netcore mongodb test application.

* Expands the rest of MongoDb tests to test against .net core test application.

* removes irrelevant ref.

* Remove RIDs from test app project files; handle Process.HasExited exception

* Attempt to solve .exe issue

Co-authored-by: Basil <tehbio@gmail.com>
Co-authored-by: Vu Tran <56414817+vuqtran88@users.noreply.github.com>
* ArtifactBuilder updates for new linux artifacts.

* Script + workflow updates for Linux ARM64 artifacts.

* Fixed Artifact default value.

* Fix for expired CA.

* Added commands to remove expired cert. (#748)

* Updated to handle multiple file checksums.
* renaming deploy.yml to deploy_agent.yml to better call out its function

* Updates repoman-promote.bash for arm64

* Updates deploy-packages.bash for arm64

* Updates debain conf files for arm64

* Undo deploy rename
* Using named pipes for test application process control

* Get test using AspNetCoreMvcBasicRequestsApplication to pass on Windows

* Refactor test app lifecycle management into helper library

* Refactor lifecycle management for AspNetCore3BasicWebApiApp

* Refactored several apps to use shared lifecycle management code

* oops, missed a spot

* Refactor SerilogSumologic app

* Move net core attribute instrumentation tests to use ConsoleMF app

* Remove NetCoreAttributeInstrumentationFixture

* Unify framework and core attribute instrumentation tests
Removes old linux-release folder
Adds linux-arm64-release with the .so from the old folder
Adds linux-arm64-release with the so from https://github.com/newrelic/newrelic-dotnet-agent/actions/runs/1356682557
Updates profiler build.ps1 with the new-correct path (this is only used locally)
* Using named pipes for test application process control

* Get test using AspNetCoreMvcBasicRequestsApplication to pass on Windows

* Refactor test app lifecycle management into helper library

* Refactor lifecycle management for AspNetCore3BasicWebApiApp

* Refactored several apps to use shared lifecycle management code

* oops, missed a spot

* Refactor SerilogSumologic app

* Move net core attribute instrumentation tests to use ConsoleMF app

* Remove NetCoreAttributeInstrumentationFixture

* Unify framework and core attribute instrumentation tests

* Attempt to fix Linux issues with EnvironmentTests

* Add comment about nullable total ram field

* Update Rejit tests to use Path.Combine instead of explicit backslash

* Use Path.Combine in InterfaceDefaultsInstrumentationTests

* Use Path.Combine in DetachWrapperTests

* Use Path.Combine in AspNetCoreMvcAsyncTests

* Path.Combine ALL THE THINGS

* Somehow AspNet5BasicWebApiApplication wasn't in the solution so it was missed when making all the named pipe changes

* Fix framework/core inconsistency in headers tests

* Update test app for netcore thread profiling tests to .NET 5 to support Linux testing

* Add a method to skip tests on Linux and apply them to the logging tests

* Fix test class cleanup error for skipped test
* Added commands to remove expired cert. (#748)

* Update mongodb tests (#747)

* Updates MongDb driver to v2.13.1.
Adds CoreIndexManger related tests to test against a net core test application.
Refactors tests.

* fixes failed test endpoints due to incorrectly exercises mongodb apis.

* Expands AsyncCursorsTests tests to NetCore test application.

* Expands IndexManagerTests tests to the netcore mongodb test application.

* Expands the rest of MongoDb tests to test against .net core test application.

* removes irrelevant ref.

* Fix agent hang on startup. (#753)

* Adds "System.Net.HttpWebRequest.GetResponse" to the DeferInitializationOnTheseMethods list.

Removes confusing/incorrect logging message.

* Update CHANGELOG.md

* fixes grammar.

* Re-enable unbounded tests in workflow (#765)

* Added GHA step to run integration tests on linux-arm64.

* Updated CHANGELOG.md

Co-authored-by: Vu Tran <56414817+vuqtran88@users.noreply.github.com>
Co-authored-by: Alex Hemsath <57361211+nr-ahemsath@users.noreply.github.com>
@tehbio tehbio added this to the AWS Graviton ARM64 support milestone Oct 25, 2021
Copy link
Contributor

@vuqtran88 vuqtran88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -6,7 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased] changes
### New Features
* Feature [#365](https://github.com/newrelic/newrelic-dotnet-agent/issues/365): This version adds support for the Linux ARM64/AWS Graviton2 platform using .NET 5.0. ([#768](https://github.com/newrelic/newrelic-dotnet-agent/pull/768))
* Includes a new `Processor Architecture` property reported by the Agent with the Environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space.

@tehbio tehbio merged commit 3ca307c into main Oct 26, 2021
@nr-ahemsath nr-ahemsath deleted the arm64-feature-branch branch November 12, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants