Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to catch and log json serialization errors #715

Merged
merged 3 commits into from
Sep 10, 2021
Merged

Update to catch and log json serialization errors #715

merged 3 commits into from
Sep 10, 2021

Conversation

tehbio
Copy link
Contributor

@tehbio tehbio commented Sep 9, 2021

Description

Resolves #502 with some better handling of the json object serialization calls.

nr-ahemsath
nr-ahemsath approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@nr-ahemsath nr-ahemsath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. All unit and integration tests (including unbounded) pass for me locally.

@tehbio tehbio merged commit fe4a036 into main Sep 10, 2021
@tehbio tehbio deleted the safe-json-deser branch September 10, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nr-ahemsath nr-ahemsath nr-ahemsath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent encountering serialization error
2 participants
@tehbio @nr-ahemsath