Update Mvc3 instrumentation to better handle Controller and Action misses #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to instead move the added validation logic to a new |
vuqtran88
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #155 by adding some extra
Mvc3instrumentation to handle missing Controllers or Actions already targeted by the Route.These request transactions now get appropriately named
WebTransaction/StatusCode/404, mirroringAspNetCoreinstrumentation.Testing
Included is an update to the
BasicMvcApplicationintegration test to include these types of 404 requests, and validate that they are no longer generating MGI.