Update StackTraces.ScrubAndTruncate to handle zero max depth #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehbio
approved these changes
Apr 7, 2021
|
Converted to draft while waiting for answers to some questions. There is a question of whether a config value of "0" should actually mean "0", or if it should mean "infinity". I checked the agent specs for error traces and I didn't find an answer either way. I'm working on getting input from other agent teams to see what they do. |
|
No conclusive feedback either way; all our integration tests pass for me locally with this change, and it also seems unlikely that the backend would like the agent to send them an "infinite" amount of stack frames in any case. Going ahead with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #522 by adjusting the logic of the
StackTraces.ScrubAndTruncatemethod to return an empty list when themaxDepthparameter is set to 0.Testing
Added one unit test to cover this case. I also manually tested a test app that threw an exception from a stack depth of 3 and verified that no stack trace lines are sent in the
errordata whenmaxStackTraceLinesis set to 0 in the agent config file.Changelog
Changelog is updated.