Use AppDomain.CurrentDomain.BaseDirectory to get path of appsettings*.json #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lspangler584
reviewed
Dec 7, 2020
| { | ||
| // Fall back to previous behavior | ||
| applicationDirectory = Directory.GetCurrentDirectory(); | ||
| } | ||
| var environment = env.GetEnvironmentVariable("ASPNETCORE_ENVIRONMENT"); |
There was a problem hiding this comment.
Code org nit: Can we move var env declaration to right before where it is used on line 38?
Similarly, Can we move the block that sets/checks var environment to right before it is used on line 48?
lspangler584
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #116 by using
AppDomain.CurrentDomain.BaseDirectoryinstead ofDirectory.GetCurrentDirectory()to get the path where an application'sappsettings.jsonfile(s) should be.Testing
Manually tested an ASP.NET Core 2.2 application hosted in a Windows service. Prior to this fix, this app could not read its New Relic application name setting from
appsettings.jsoneven though it was there. After the fix, the app is named correctly as expected. I also tested some other cases (.NET 5.0 console application, ASP.NET Core 2.2 and 3.1 apps hosted in IIS in-process) and app naming via appsettings.json worked as expected.Changelog
Will update changelog once I have a PR # for this PR.