Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update profiler to support responding to changes in ignored instrumentation. #2236

Conversation

nrcventura
Copy link
Member

@nrcventura nrcventura commented Feb 9, 2024

Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.

Description

Updates the profiler to refresh the ignored instrumentation list. Applies the ignore list check to the collection of instrumentation points instead of functions so that we can get consistent behavior in all of the places that check instrumentation points.

These changes were validated manually by disabling and re-enabling some built in instrumentation.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feature/disable-inst-by-config@1d17308). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                        @@
##             feature/disable-inst-by-config    #2236   +/-   ##
=================================================================
  Coverage                                  ?   73.15%           
=================================================================
  Files                                     ?      440           
  Lines                                     ?    27428           
  Branches                                  ?     2999           
=================================================================
  Hits                                      ?    20064           
  Misses                                    ?     6576           
  Partials                                  ?      788           

@nrcventura nrcventura marked this pull request as ready for review February 9, 2024 23:37
@nrcventura nrcventura merged commit 2c9447d into feature/disable-inst-by-config Feb 10, 2024
77 checks passed
@nrcventura nrcventura deleted the feature-work/refresh-instr-ignore-list branch February 10, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants