Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Report ignored instrumentation usage #2227

Conversation

nrcventura
Copy link
Member

@nrcventura nrcventura commented Feb 2, 2024

Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.

Description

Reports the configured ignored instrumentation with the agent settings and generates a supportability metric to when any ignored instrumentation is configured.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feature/disable-inst-by-config@75c24a9). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                        @@
##             feature/disable-inst-by-config    #2227   +/-   ##
=================================================================
  Coverage                                  ?   81.08%           
=================================================================
  Files                                     ?      396           
  Lines                                     ?    24737           
  Branches                                  ?     2999           
=================================================================
  Hits                                      ?    20058           
  Misses                                    ?     3890           
  Partials                                  ?      789           

@nrcventura nrcventura merged commit 4c332fc into feature/disable-inst-by-config Feb 5, 2024
77 checks passed
@nrcventura nrcventura deleted the feature-work/report-ignore-instr-usage branch February 5, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants