Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an integration test for Vulnerability Management to AgentFeatures group. #1681

Merged

Conversation

jaffinito
Copy link
Member

Description

  • Adds configuration to the UpdateLoadedModulesService so that we can change the cycle time for testing.
  • Adds an integration test for Vulnerability Management to AgentFeatures group.

The what, the why and the how of your PR.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@jaffinito jaffinito marked this pull request as ready for review June 1, 2023 19:08
Copy link
Member

@tippmar-nr tippmar-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feature/vulnerability-management@7457eb9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                         Coverage Diff                         @@
##             feature/vulnerability-management    #1681   +/-   ##
===================================================================
  Coverage                                    ?   82.65%           
===================================================================
  Files                                       ?      389           
  Lines                                       ?    24395           
  Branches                                    ?        0           
===================================================================
  Hits                                        ?    20164           
  Misses                                      ?     4231           
  Partials                                    ?        0           

@jaffinito jaffinito merged commit 8f11c36 into feature/vulnerability-management Jun 1, 2023
@jaffinito jaffinito deleted the test/integration-tests-vuln-mgmt branch June 1, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants